Included create_ssl_context function to create the same context with SSLConfig and serve as API#996
Merged
lovelydinosaur merged 7 commits intoencode:masterfrom Jul 27, 2020
Conversation
tests/test_config.py
Outdated
| @@ -38,10 +36,11 @@ def test_load_ssl_config_verify_env_file(https_server, ca_cert_pem_file, config) | |||
| else str(Path(ca_cert_pem_file).parent) | |||
| ) | |||
| ssl_config = SSLConfig(trust_env=True) | |||
Contributor
There was a problem hiding this comment.
It'd be great as part of this change if we dropped using the private SSLConfig from the tests completely.
Not necessarily a blocker to getting this PR in, but might be worth a go?
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Fantastic stuff! I've put a few inline comments here.
There's also a bit of thinking we'll want to do wrt. if http2 properly lives on the SSL configuration, or on the transport, or both, but I'm not going to go into that here.
cansarigol
force-pushed
the
create_ssl_context
branch
from
4e074b8 to
98cfdea
Compare
added 4 commits
June 3, 2020 22:07
…SSLConfig and serve as API.
…LConfig using from tests
cansarigol
force-pushed
the
create_ssl_context
branch
from
98cfdea to
8a9d263
Compare
Merged
lovelydinosaur
approved these changes
Jul 27, 2020
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Looks great yup!
I'll leave it open briefly in case anyone else also want to take a review onto it, but otherwise we'll get this into 0.14.
Thanks so much !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #983